Skip to content

fix: fixed copied text UI issue#2143

Closed
Shriya-Chauhan wants to merge 6 commits intoasyncapi:masterfrom
Shriya-Chauhan:shri
Closed

fix: fixed copied text UI issue#2143
Shriya-Chauhan wants to merge 6 commits intoasyncapi:masterfrom
Shriya-Chauhan:shri

Conversation

@Shriya-Chauhan
Copy link
Contributor

@Shriya-Chauhan Shriya-Chauhan commented Jan 2, 2025 •
edited
Loading

Description

#2142 : Isuue Number
'Copied! ' text replaced with tick icon.

Related Issue

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

image

@netlify
Copy link

netlify bot commented Jan 2, 2025 •
edited
Loading

✅ Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 84089b9
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6776d7814770bb000844e133
😎 Deploy Preview https://deploy-preview-2143--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jan 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12652218542

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.319%
Totals Coverage Status
Change from base Build 12264516506: 0.0%
Covered Lines: 6004
Relevant Lines: 6335
💛 - Coveralls

@Shriya-Chauhan Shriya-Chauhan changed the title fix: Bug #2142 fix: bug 2142 - Copied text UI issue fixed Jan 2, 2025
@Shriya-Chauhan Shriya-Chauhan mentioned this pull request Jan 2, 2025
Closed
2 tasks
@ashmitjsg ashmitjsg changed the title fix: bug 2142 - Copied text UI issue fixed fix: fixed copied text UI issue Jan 6, 2025
ashmitjsg
ashmitjsg requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@ashmitjsg ashmitjsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shriya-Chauhan add the issue number in the description instead of the PR title. Also, fix the failing tests. Besides that changes looks good to me.

@Shriya-Chauhan Shriya-Chauhan reopened this Jan 7, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Shriya-Chauhan
Copy link
Contributor Author

Shriya-Chauhan commented Jan 7, 2025

image

I have created one file and updated one of the existing files. Can you please help me fix this issue? @devilkiller-ag

@chaitanyakadu
Copy link

chaitanyakadu commented Jan 7, 2025

image

I have created one file and updated one of the existing files. Can you please help me fix this issue? @devilkiller-ag

I think this is due to the absence of C# compiler installed in the environment by default. @devilkiller-ag should we install .NET SDK? Kindly correct me!

Bellow changes can be implemented in the .github/workflows/blackbox-testing.yml ci workflow.
Setup .NET so that csc is available
name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: '7.0.0'

@jonaslagoni
Copy link
Member

jonaslagoni commented Jan 24, 2025

When doing frontend work, completely ignore blackbox :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashmitjsg ashmitjsg ashmitjsg requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Shriya-Chauhan @coveralls @chaitanyakadu @jonaslagoni @ashmitjsg